Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_load_remote_dataset: Add the "kind" attribute to explicitly specify if data is a grid or image #3688

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 13, 2024

Description of proposed changes

For remote datasets, we need to know if it's a grid or an image. Currently, we do below:

kind = "image" if name in {"earth_day", "earth_night"} else "grid"

So, kind defaults to grid but is set to image for two special datasets.

This PR adds the kind attribute to explicitly specify if data is a grid or an image.

Let me know if you're OK with the changes.

@seisman seisman added the discussions Need more discussion before taking further actions label Dec 13, 2024
@seisman seisman added this to the 0.14.0 milestone Dec 16, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. and removed discussions Need more discussion before taking further actions labels Dec 16, 2024
@seisman seisman marked this pull request as ready for review December 16, 2024 11:35
@seisman seisman removed the needs review This PR has higher priority and needs review. label Dec 18, 2024
@seisman seisman removed this from the 0.14.0 milestone Dec 18, 2024
@seisman seisman added this to the 0.15.0 milestone Jan 4, 2025
@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 4, 2025
@seisman seisman requested a review from a team January 7, 2025 00:19
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 7, 2025
@seisman seisman changed the title _load_remote_dataset: Add the 'kind' attribute to explicitly specify if data is a grid or image _load_remote_dataset: Add the "kind" attribute to explicitly specify if data is a grid or image Jan 7, 2025
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 8, 2025
@seisman seisman merged commit aeaf33f into main Jan 8, 2025
22 of 23 checks passed
@seisman seisman deleted the load_remote_dataset branch January 8, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants