Add the private _to_numpy function to convert anything to a numpy array #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e318764 to
0f8d82f
Compare
michaelgrund
approved these changes
Nov 5, 2024
weiji14
approved these changes
Nov 5, 2024
This was referenced Nov 5, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
seisman
added a commit
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new private function,
_to_numpy,designed to convert various data types into numpy dtypes. This function is extracted from the existingvectors_to_arraysfunction without any code changes, greatly simplifying thevectors_to_arraysfunction.This enhancement is the first step towards supporting more numpy/pandas/pyarrow dtypes. With this PR, we can easily check if a dtype can be converted to a recognized numpy dtype (see #3513 for a POC PR). The plan is to add more tests for various dtypes in a series of PRs.
Related to #2848 (comment), #3513, #2800, #2933, #3507.