Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot square or cube by default for geopandas Point/MultiPoint types #1405

Merged
Merged
Changes from 6 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
56f5c54
adding if statement for geopandas default behavior.
yohaimagen Aug 2, 2021
ef2e89a
format corections
yohaimagen Aug 2, 2021
af36475
chcking that data is an object to be sure it has __dict__ (make sure …
yohaimagen Aug 2, 2021
e1543e8
Update pygmt/src/plot.py
yohaimagen Aug 2, 2021
d60ee1b
not checking if data is not None allrady been verefide in data_kind f…
yohaimagen Aug 2, 2021
4bd2d5e
reformat style
yohaimagen Aug 3, 2021
93c5312
Update pygmt/src/plot.py
yohaimagen Aug 3, 2021
5daeb42
Update pygmt/src/plot.py
yohaimagen Aug 3, 2021
2041146
adding the if statment to plot3d.py
yohaimagen Aug 3, 2021
9f69437
changing the style to s-.2c and u0.2c for plot and plot3d respectivly
yohaimagen Aug 3, 2021
6409d34
testing defualt behavior of plot and plot3d with geopandas Point and …
yohaimagen Aug 4, 2021
7a60c4f
style reformat
yohaimagen Aug 4, 2021
dd1c9b8
style reformat imports
yohaimagen Aug 4, 2021
1979249
add comments to new tests
yohaimagen Aug 4, 2021
966c9e5
reformat imports
yohaimagen Aug 5, 2021
35e66d1
Update pygmt/tests/test_geopandas.py
yohaimagen Aug 6, 2021
1590a26
Update pygmt/tests/test_geopandas.py
yohaimagen Aug 6, 2021
b2204ad
change the test figuers size to make smaller sizewd figuers
yohaimagen Aug 6, 2021
702b038
Merge branch 'main' into geopandas-point-default-style
michaelgrund Aug 8, 2021
0b642a9
adding test for non defualt style
yohaimagen Aug 11, 2021
5d778f1
adding a coment explaining the if statment
yohaimagen Aug 12, 2021
e36b3eb
reformat
yohaimagen Aug 12, 2021
96b683c
Update pygmt/src/plot.py
yohaimagen Aug 14, 2021
e57ec91
Update pygmt/src/plot3d.py
yohaimagen Aug 14, 2021
d9a02a7
Merge branch 'main' into geopandas-point-default-style
seisman Aug 14, 2021
4d13394
Update pygmt/tests/test_geopandas.py
yohaimagen Aug 17, 2021
b7827e0
Update pygmt/tests/test_geopandas.py
yohaimagen Aug 17, 2021
d62608c
reformat
yohaimagen Aug 17, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pygmt/src/plot.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ def plot(self, x=None, y=None, data=None, size=None, direction=None, **kwargs):
extra_arrays = []
if "S" in kwargs and kwargs["S"][0] in "vV" and direction is not None:
extra_arrays.extend(direction)
elif "S" not in kwargs and kind == "geojson" and (data.geom_type == "Point").all():
yohaimagen marked this conversation as resolved.
Show resolved Hide resolved
kwargs["S"] = "s0.2c"
yohaimagen marked this conversation as resolved.
Show resolved Hide resolved
if "G" in kwargs and not isinstance(kwargs["G"], str):
if kind != "vectors":
raise GMTInvalidInput(
Expand Down