-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON Transaction submitter #339
Conversation
a563204
to
6c15470
Compare
6c15470
to
2629597
Compare
highlight={(code) => highlight(code, languages.json, 'json')} | ||
padding={10} | ||
style={{ | ||
fontFamily: '"Fira code", "Fira Mono", monospace', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you make sure that this font family is present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it is embedded since it's the one used in the documentation of the library
}`; | ||
|
||
return ( | ||
<PageWithReturn title="Build Transaction" onBackClick={handleBack}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rename it sign transaction locally, build doesn't really mean anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have renamed into ''Submit Raw Transaction''
7e9c040
to
8f65f1f
Compare
No description provided.