Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Bulk Transactions view #321

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

ThibautBremand
Copy link
Collaborator

No description provided.

@ThibautBremand ThibautBremand added enhancement New feature or request refactor labels Oct 14, 2023
@ThibautBremand ThibautBremand self-assigned this Oct 14, 2023
@ThibautBremand ThibautBremand marked this pull request as ready for review October 15, 2023 09:37
@@ -26,6 +24,9 @@ export const RecapView: React.FC<RecapProps> = ({
handleReject,
beginProcess
}) => {
const [isDataExpanded, setIsDataExpanded] = useState(false);
const [isFeeExpanded, setIsFeeExpanded] = useState(false);

const getTransactionCountsByType = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this MR but it seems that this should be wrapped within a useMemo

@ThibautBremand ThibautBremand force-pushed the feat/revamp-bulk-tx-view branch from 8b66848 to 8436059 Compare October 19, 2023 19:10
@ThibautBremand ThibautBremand merged commit 3cf9c63 into master Oct 20, 2023
3 checks passed
@ThibautBremand ThibautBremand deleted the feat/revamp-bulk-tx-view branch October 20, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants