Update code post review

GemWallet · Aug 20, 2023 · c47d0b3 · c47d0b3
1 parent eefb4f7
commit c47d0b3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/packages/api/src/submitTransactionsBulk/submitTransactionsBulk.ts b/packages/api/src/submitTransactionsBulk/submitTransactionsBulk.ts
@@ -21,7 +21,7 @@ export const submitTransactionsBulk = async (
   };
 
   if (payload.transactions.length === 0 || payload.transactions.length > MAX_TRANSACTIONS) {
-    throw new Error('Invalid number of transactions');
+    throw new Error(`Invalid number of transactions (must be between 1 and ${MAX_TRANSACTIONS})`);
   }
 
   try {

diff --git a/packages/constants/src/network/network.constant.ts b/packages/constants/src/network/network.constant.ts
@@ -10,12 +10,9 @@ export enum NetworkServer {
   MAINNET = 'wss://xrplcluster.com',
   TESTNET = 'wss://s.altnet.rippletest.net:51233',
   DEVNET = 'wss://s.devnet.rippletest.net:51233',
-  AMM_DEVNET = 'wss://amm.devnet.rippletest.net:51233'
-}
-
-export enum MainnetClioServer {
-  S1 = 'wss://s1.ripple.com',
-  S2 = 'wss://s2.ripple.com'
+  AMM_DEVNET = 'wss://amm.devnet.rippletest.net:51233',
+  MAINNET_S1 = 'wss://s1.ripple.com', // Clio
+  MAINNET_S2 = 'wss://s2.ripple.com' // Clio
 }
 
 export const NETWORK = {

diff --git a/packages/extension/src/contexts/LedgerContext/LedgerContext.tsx b/packages/extension/src/contexts/LedgerContext/LedgerContext.tsx
@@ -38,9 +38,9 @@ import {
   CreateNFTOfferRequest,
   CreateOfferRequest,
   GetNFTRequest,
-  MainnetClioServer,
   MintNFTRequest,
   Network,
+  NetworkServer,
   NFTData,
   NFTokenIDResponse,
   SendPaymentRequest,
@@ -892,9 +892,9 @@ const LedgerProvider: FC = ({ children }) => {
           // Connect to Clio server for mainnet
           let clioClient;
           try {
-            clioClient = await connectToLedger(MainnetClioServer.S1);
+            clioClient = await connectToLedger(NetworkServer.MAINNET_S1);
           } catch {
-            clioClient = await connectToLedger(MainnetClioServer.S2).catch(() => {
+            clioClient = await connectToLedger(NetworkServer.MAINNET_S2).catch(() => {
               throw new Error("Couldn't connect to a Clio server");
             });
           }
-Original file line number
+Diff line change
@@ Expand Up / @@ -21,7 +21,7 @@ export const submitTransactionsBulk = async ( @@
       };
       if (payload.transactions.length === 0 || payload.transactions.length > MAX_TRANSACTIONS) {
-        throw new Error('Invalid number of transactions');
+        throw new Error(`Invalid number of transactions (must be between 1 and ${MAX_TRANSACTIONS})`);
       }
       try {
@@ Expand Down @@