Fix to include static settings in addition to dynamic repo metadata s…

…ettings during s3 plugin reload (opensearch-project#10452) Signed-off-by: vikasvb90 <vikasvb@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Gaurav614 · Apr 25, 2024 · 35a8a91 · 35a8a91
1 parent e3601e0
commit 35a8a91
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3Repository.java b/plugins/repository-s3/src/main/java/org/opensearch/repositories/s3/S3Repository.java
@@ -374,9 +374,8 @@ public void reload(RepositoryMetadata newRepositoryMetadata) {
         readRepositoryMetadata();
 
         // Reload configs for S3RepositoryPlugin
-        final Map<String, S3ClientSettings> clientsSettings = S3ClientSettings.load(metadata.settings(), pluginConfigPath);
-        service.refreshAndClearCache(clientsSettings);
-        s3AsyncService.refreshAndClearCache(clientsSettings);
+        service.settings(metadata);
+        s3AsyncService.settings(metadata);
 
         // Reload configs for S3BlobStore
         BlobStore blobStore = getBlobStore();