Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commands): improve /xp #17

Merged
merged 9 commits into from
Jul 14, 2024
Merged

feat(commands): improve /xp #17

merged 9 commits into from
Jul 14, 2024

Conversation

ToastedDev
Copy link
Contributor

@ToastedDev ToastedDev commented Jul 14, 2024 •
edited
Loading

  • adds a rankcard image, which allows for a much better UI
    image
  • adds user option, which allows the runner to specify what user to get the xp of

@ToastedDev ToastedDev requested a review from GalvinPython as a code owner July 14, 2024 01:38
@ToastedDev
Copy link
Contributor Author

because of this change we should probably rename /xp to /rank, but that's a debate for another day

GalvinPython
GalvinPython reviewed Jul 14, 2024
View reviewed changes
bot/commands.ts Outdated Show resolved Hide resolved
GalvinPython
GalvinPython reviewed Jul 14, 2024
View reviewed changes
bot/commands.ts Outdated Show resolved Hide resolved
GalvinPython
GalvinPython requested changes Jul 14, 2024
View reviewed changes
Copy link
Owner

@GalvinPython GalvinPython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need .toLocaleString() back lol

bot/commands.ts Outdated Show resolved Hide resolved
@ToastedDev ToastedDev requested a review from GalvinPython July 14, 2024 07:37
GalvinPython
GalvinPython requested changes Jul 14, 2024
View reviewed changes
bot/commands.ts Outdated Show resolved Hide resolved
bot/commands.ts Outdated Show resolved Hide resolved
@ToastedDev ToastedDev requested a review from GalvinPython July 14, 2024 09:20
@ToastedDev ToastedDev changed the title feat(bot): add rankcard feat(commands): improve /xp Jul 14, 2024
@GalvinPython GalvinPython merged commit 03d759d into GalvinPython:dev Jul 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalvinPython GalvinPython GalvinPython approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToastedDev @GalvinPython