Feature: handle lnurl success action #3362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-completed-screen
dolcalmi
requested changes
Feb 19, 2025
app/screens/send-bitcoin-screen/send-bitcoin-completed-screen.tsx
Outdated
Show resolved
Hide resolved
app/screens/send-bitcoin-screen/send-bitcoin-confirmation-screen.tsx
Outdated
Show resolved
Hide resolved
app/screens/send-bitcoin-screen/send-bitcoin-details-screen.tsx
Outdated
Show resolved
Hide resolved
app/screens/send-bitcoin-screen/send-bitcoin-details-screen.tsx
Outdated
Show resolved
Hide resolved
dolcalmi
requested changes
Feb 28, 2025
| SuccessLUD09Message, | ||
| SuccessLUD09URL, | ||
| SuccessLUD09URLWithDesc, | ||
| } from "../../app/screens/send-bitcoin-screen/send-bitcoin-completed-screen.stories" |
There was a problem hiding this comment.
please use @app/screens/...
| @@ -381,6 +381,15 @@ const SendBitcoinDetailsScreen: React.FC<Props> = ({ route }) => { | |||
| } | |||
|
|
|||
| const result = await requestInvoice(requestInvoiceParams) | |||
|
|
|||
| setPaymentDetail((prev) => { | |||
There was a problem hiding this comment.
again, why prev? this is more like paymentDetail
|
|
||
| setPaymentDetail((prev) => { | ||
| if (prev?.setSuccessAction) { | ||
| return prev.setSuccessAction(result.successAction) |
There was a problem hiding this comment.
what happen if result.successAction is undefined? maybe better add && result.successAction to the if
| @@ -396,6 +405,10 @@ const SendBitcoinDetailsScreen: React.FC<Props> = ({ route }) => { | |||
| paymentRequest: invoice, | |||
| paymentRequestAmount: btcAmount, | |||
| }) | |||
|
|
|||
| paymentDetailForConfirmation = | |||
There was a problem hiding this comment.
what if result.successAction is undefined?
| @@ -154,6 +154,8 @@ const SendBitcoinConfirmationScreen: React.FC<Props> = ({ route }) => { | |||
| params: { | |||
| arrivalAtMempoolEstimate: extraInfo?.arrivalAtMempoolEstimate, | |||
| status, | |||
| successAction: paymentDetail?.successAction, | |||
| preimage: extraInfo?.preimage, | |||
| </View> | ||
| </View> | ||
| )} | ||
| <TouchableOpacity |
There was a problem hiding this comment.
please add accessibility label on touchable elements
There was a problem hiding this comment.
you are missing aes test... you can use this data
successAction: {
tag: "aes",
description: "Here is your redeem code",
ciphertext: "564u3BEMRefWUV1098gJ5w==",
iv: "IhkC5ktKB9LG91FvlbN2kg==",
},
preimage: "25004cd52960a3bac983e3f95c432341a7052cef37b9253b0b0b1256d754559b",
Comment on lines
61
to
62
| successAction: undefined, | ||
| preimage: undefined, |
There was a problem hiding this comment.
if they are undefined then there is no need to set them here
Comment on lines
42
to
43
| successAction: undefined, | ||
| preimage: undefined, |
…adding accesibility labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented: LNURL successAction: LUD-09, LUD-10