Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send flow but animated #3148

Merged
merged 10 commits into from
Apr 5, 2024
Merged

feat: send flow but animated #3148

merged 10 commits into from
Apr 5, 2024

Conversation

sandipndev
Copy link
Member

@sandipndev sandipndev commented Mar 31, 2024

Description

This PR implements animations for Bitcoin Send flow.

  • Animations for all three forms: success (green check mark), eventual success (yellow clock) and failure (red cross).
  • Haptics at the time of send/failure
  • Minimum 2s for animation to complete even if the send is immediate (felt by the haptic) so that the UI feels reactive.

Screenshots for types of payments

Lighting Payment Bitcoin Payment Intraledger Payment
Simulator Screenshot - iPhone SE (3rd generation) - 2024-03-31 at 20 22 46 Simulator Screenshot - iPhone SE (3rd generation) - 2024-03-31 at 20 23 33 image

Recordings

Please wait a few seconds for the animation videos to load (~4 MB download).
Android animations performed slower in emulator (not an issue on device). So in these recordings you get to see how the animations will feel both slowly and fast)

"Send Success - Android" Animation "Send Failure - Android" Animation
Animation 1 Animation 2
"Send Success - iOS" Animation "Send Failure - iOS" Animation
Animation 3 Animation 4

All the animations were developed wholeheartedly by Liam. Thank you for your contribution, sir! ❤️

@nicolasburtey
Copy link
Member

approving for now, even if I think the animation are somewhat over the top. I want to see how it feels when using the wallet. we can revert before next rollout if we're not on an agreement on what to do with this

@nicolasburtey
Copy link
Member

approving for now, even if I think the animation are somewhat over the top. I want to see how it feels when using the wallet. we can revert before next rollout if we're not on an agreement on what to do with this

actually after skimming through the code, there is a lot of code commented, so have questions on that

@sandipndev sandipndev force-pushed the send-animations branch 2 times, most recently from ea86b72 to 612af15 Compare April 5, 2024 06:09
chore: initial draft

chore: has the full animation flow

chore: a little more optimization

process the status text as before

feat: all animations added

done
@sandipndev
Copy link
Member Author

approving for now, even if I think the animation are somewhat over the top. I want to see how it feels when using the wallet. we can revert before next rollout if we're not on an agreement on what to do with this

I've confirmed that there isn't any commented ghost code and have resolved your concerns on the PR. Based on your comment earlier, merging this to see and feel it in the app. We can revert before public if it feels over the top.

@sandipndev sandipndev merged commit d387b0c into main Apr 5, 2024
8 checks passed
@sandipndev sandipndev deleted the send-animations branch April 5, 2024 08:21
2624789 pushed a commit to 2624789/galoy-mobile that referenced this pull request Apr 11, 2024
* feat: show animations

chore: initial draft

chore: has the full animation flow

chore: a little more optimization

process the status text as before

feat: all animations added

done

* send payment detail around

* save

* chore: getting transaction

* feat: transaction detail linked

* test: fix for sends

* feat: added haptics

* chore: translations

* chore: fixes

* chore: addressing comments and removing commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants