-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send flow but animated #3148
Conversation
approving for now, even if I think the animation are somewhat over the top. I want to see how it feels when using the wallet. we can revert before next rollout if we're not on an agreement on what to do with this |
app/screens/send-bitcoin-screen/send-bitcoin-confirmation-screen.tsx
Outdated
Show resolved
Hide resolved
app/screens/send-bitcoin-screen/send-bitcoin-confirmation-screen.tsx
Outdated
Show resolved
Hide resolved
actually after skimming through the code, there is a lot of code commented, so have questions on that |
ea86b72
to
612af15
Compare
chore: initial draft chore: has the full animation flow chore: a little more optimization process the status text as before feat: all animations added done
612af15
to
8071b22
Compare
8071b22
to
a3ddab3
Compare
I've confirmed that there isn't any commented ghost code and have resolved your concerns on the PR. Based on your comment earlier, merging this to see and feel it in the app. We can revert before public if it feels over the top. |
* feat: show animations chore: initial draft chore: has the full animation flow chore: a little more optimization process the status text as before feat: all animations added done * send payment detail around * save * chore: getting transaction * feat: transaction detail linked * test: fix for sends * feat: added haptics * chore: translations * chore: fixes * chore: addressing comments and removing commented code
Description
This PR implements animations for Bitcoin Send flow.
Screenshots for types of payments
Recordings
Please wait a few seconds for the animation videos to load (~4 MB download).
Android animations performed slower in emulator (not an issue on device). So in these recordings you get to see how the animations will feel both slowly and fast)
All the animations were developed wholeheartedly by Liam. Thank you for your contribution, sir! ❤️