test(e2e): detox tests #3080
Closed
test(e2e): detox tests #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fef5f3 to
3befcd9
Compare
b901ea5 to
f3c4612
Compare
dd085ef to
017fe15
Compare
ci: test chore: try macos ci: test if everything works ci: upload recordings test try emulator creation manually export JAVA_HOME="/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home" ci: single e2e test export JAVA_HOME="/Library/Java/JavaVirtualMachines/zulu-11.jdk/Contents/Home"
017fe15 to
fa8e111
Compare
|
Blocked on this because somehow the Galoy API in quickstart reports zero balances after funds have been sent to user's btc/usd accounts. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 7652397 | Triggered | Generic High Entropy Secret | 58aac80 | dev/vendor/galoy-quickstart/dev/core-bundle/serve-env.json | View secret |
| 7652397 | Triggered | Generic High Entropy Secret | 58aac80 | dev/vendor/galoy-quickstart/dev/core-bundle/integration-env.json | View secret |
| 7652397 | Triggered | Generic High Entropy Secret | 58aac80 | dev/vendor/galoy-quickstart/dev/Tiltfile | View secret |
| 9485054 | Triggered | Generic Private Key | 58aac80 | dev/vendor/galoy-quickstart/dev/config/notifications/fake_service_account.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
7a7ab46 to
7936579
Compare
chore: recv test: destroy backend save check code save chore: update quickstart which also fix funding issue fix: e2e change ios device more time
7936579 to
58aac80
Compare
b457cd9 to
36b2fff
Compare
36b2fff to
1c77dd0
Compare
6d79e9c to
ea54ecc
Compare
ea54ecc to
cd556bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following flows to Detox:
LNURL PayLNURL Withdraw#3079 should be merged first