Explicitly check mir-json schema version
#2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauclovian-g
approved these changes
Feb 19, 2025
|
How would you propose splitting up the commit, out of curiosity? |
|
I'd probably separate out all the mir-json updates, probably do them first since they don't actually depend on the rest. One might also split the submodule bumps from the rest for visibility; there was some talk about that last summer. |
This regenerates all version-controlled MIR JSON files to use `mir-json` commit GaloisInc/mir-json@c52b16b, which adds a schema version to the JSON. For now, SAW simply ignores these version numbers, but a subsequent commit will update SAW to explicitly check for them.
This ensures that SAW is only ever loading MIR JSON files that are known to be supported. (See also GaloisInc/crucible#1309 for similar changes on the Crux-MIR side.) Fixes #2111. This bumps the following submodules: * `crucible` (bringing in the changes from GaloisInc/crucible#1309) * `mir-json` (bringing in the changes from GaloisInc/mir-json#75)
This documents the expectations surrounding SAW's requirements for `mir-json` schema versions in the `README`. It also advertises the fact that we check for schema versions in the changelog.
18c51de to
05d7c89
Compare
|
I've force-pushed a new version of the PR that splits the changes into three separate commits. |
|
I did say I didn't think that was worth the trouble :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that SAW is only ever loading MIR JSON files that are known to be supported. (See also GaloisInc/crucible#1309 for similar changes on the Crux-MIR side.)
Fixes #2111.
This bumps the following submodules:
crucible(bringing in the changes fromcrucible-mir: Explicitly checkmir-jsonschema version crucible#1309)mir-json(bringing in the changes from Explicitly version the JSON schema mir-json#75)