-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement of build workflow #68
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #68 +/- ##
==========================================
Coverage ? 96.68%
==========================================
Files ? 32
Lines ? 1177
Branches ? 0
==========================================
Hits ? 1138
Misses ? 39
Partials ? 0 Continue to review full report at Codecov.
|
a0f81c9
to
e652255
Compare
@Galileo-Galilei there's a great Markdown linter you might be interested in: https://github.com/DavidAnson/markdownlint |
9464223
to
fea80b0
Compare
Starting the review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments. Amazing work with this one!
- rename dev in test - run tests on windows and macos - upload coverage report to Codecov
- update version - CHANGELOG - create branch and PR
- create release - create tag - create PyPI release - merge back to develop
- Add badges for readibility - Add credits to maintainers - Fix command for latest installation with pip
fea80b0
to
c917197
Compare
When you confirm you are ok now, I'll rebase it locally. |
Codecov Report
@@ Coverage Diff @@
## develop #68 +/- ##
==========================================
Coverage ? 96.71%
==========================================
Files ? 32
Lines ? 1186
Branches ? 0
==========================================
Hits ? 1147
Misses ? 39
Partials ? 0 Continue to review full report at Codecov.
|
Eventually add the markdown linter suggested by @kaemo (for linting in the test workflow? it may be worth it to add it to the precommit hook too)-> I had issues on the pre-commit on windows and it seems known and not fixed. Since we have windows users, I think we should let it go for now. Are you ok with this @kaemo?