Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Correctly pass kpm_kwargs and log_model_kwargs to pipeline_ml_factory instead of always using default values (#329) #332

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

Galileo-Galilei
Copy link
Owner

@Galileo-Galilei Galileo-Galilei commented Jun 18, 2022

Description

Close #329

Development notes

  • pass kpm_kwargs and log_model_kwargs to _turn_pipeline_to_ml method of PipelineML
  • refactor merge with default for readibility

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov-commenter
Copy link

Codecov Report

Merging #332 (0deafc9) into master (a5c5781) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #332   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          910       906    -4     
=========================================
- Hits           910       906    -4     
Impacted Files Coverage Δ
kedro_mlflow/pipeline/pipeline_ml.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c5781...0deafc9. Read the comment docs.

@Galileo-Galilei Galileo-Galilei merged commit 2a699c2 into master Jun 18, 2022
@Galileo-Galilei Galileo-Galilei deleted the bug/kpm-kwargs branch June 18, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_model_kwargs and kmp_kwargs argument of pipeline_ml_factory are ignored
2 participants