Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using kedro 0.18.1 with TemplatedConfigLoader #452

Closed
sami-sweng opened this issue Sep 27, 2023 · 2 comments
Closed

Error when using kedro 0.18.1 with TemplatedConfigLoader #452

sami-sweng opened this issue Sep 27, 2023 · 2 comments

Comments

@sami-sweng
Copy link

sami-sweng commented Sep 27, 2023

If you like the repo, please give it a ⭐

Description

When using kedro 0.18.1 with TemplatedConfigLoader I get an error:

if "mlflow" not in context.config_loader.config_patterns.keys():
AttributeError: 'TemplatedConfigLoader' object has no attribute 'config_patterns'

And it seems that in effect 0.18.1 vs latest doesn't have the attribute:

https://docs.kedro.org/en/stable/kedro.config.TemplatedConfigLoader.html
https://docs.kedro.org/en/0.18.1/_modules/kedro/config/templated_config.html

Context

Upgrading kedro-mlflow from 0.10.0 with kedro 0.18.1

Cause

except is too restrictive: https://github.com/Galileo-Galilei/kedro-mlflow/blob/master/kedro_mlflow/framework/hooks/mlflow_hook.py#L68

I'll try to prep a PR to add another except

@sami-sweng sami-sweng changed the title When using kedro 0.18.1 Error when using kedro 0.18.1 with TemplatedConfigLoader Sep 27, 2023
@sami-sweng
Copy link
Author

#453

sami-sweng added a commit to sami-sweng/kedro-mlflow that referenced this issue Oct 3, 2023
Galileo-Galilei pushed a commit that referenced this issue Oct 3, 2023
@sami-sweng
Copy link
Author

Fixed by #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant