Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: benchmarks #361

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

nstarman
Copy link
Contributor

@nstarman nstarman commented Jan 8, 2025

A followup pr is necessary to get codspeed running the tests faster.
Also one to make a cron job.

@nstarman nstarman added this to the v1.1.0 milestone Jan 8, 2025
@nstarman nstarman force-pushed the tests/fix-benchmarks branch 2 times, most recently from 0b6c0fa to 8ce714e Compare January 8, 2025 04:41
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (c588f88) to head (469b4f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          44       44           
  Lines        1609     1609           
  Branches      327      327           
=======================================
  Hits         1573     1573           
  Misses         29       29           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman force-pushed the tests/fix-benchmarks branch from 8ce714e to 456e106 Compare January 8, 2025 05:32
@nstarman nstarman marked this pull request as ready for review January 8, 2025 05:41
@nstarman nstarman force-pushed the tests/fix-benchmarks branch from 469b4f3 to 456e106 Compare January 8, 2025 06:01
@nstarman nstarman modified the milestones: v1.1.0, v1.0.x Jan 8, 2025
@nstarman nstarman added the backport v1.0.x on-merge: backport to versions/v1.0.x label Jan 8, 2025
@nstarman nstarman merged commit aefd9d4 into GalacticDynamics:main Jan 8, 2025
40 of 41 checks passed
@nstarman nstarman deleted the tests/fix-benchmarks branch January 8, 2025 06:08
meeseeksmachine pushed a commit to meeseeksmachine/unxt that referenced this pull request Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #361 will not alter performance

Comparing nstarman:tests/fix-benchmarks (8ce714e) with main (aefd9d4)

Summary

✅ 168 untouched benchmarks
⁉️ 17 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main nstarman:tests/fix-benchmarks Change
⁉️ test_dimension[args0] 217.7 µs N/A N/A
⁉️ test_dimension[args1] 167.4 µs N/A N/A
⁉️ test_dimension_execute[args0] 189 µs N/A N/A
⁉️ test_dimension_execute[args1] 189.5 µs N/A N/A
⁉️ test_dimension_of_execute[args0] 669.2 µs N/A N/A
⁉️ test_dimension_of_execute[args1] 729.8 µs N/A N/A
⁉️ test_dimension_of_execute[args2] 1.3 ms N/A N/A
⁉️ test_dimension_of_execute[args3] 246.3 µs N/A N/A
⁉️ test_dimension_of_jit_compile[args0] 14.7 ms N/A N/A
⁉️ test_unit[args0] 173.9 µs N/A N/A
⁉️ test_unit[args1] 251 µs N/A N/A
⁉️ test_unit_execute[args0] 190 µs N/A N/A
⁉️ test_unit_execute[args1] 264.3 µs N/A N/A
⁉️ test_unit_of[args0] 652.8 µs N/A N/A
⁉️ test_unit_of[args1] 697 µs N/A N/A
⁉️ test_unit_of[args2] 217.9 µs N/A N/A
⁉️ test_unit_of_jit_compile[args0] 13.8 ms N/A N/A

@adriencaccia
Copy link

CodSpeed Performance Report

Hey @nstarman, co-founder of CodSpeed here, just to let you know that we had an issue on our side that prevented the reports of your runs to not be generated. We fixed the issue and regenerated the reports, so that is why they only appear now.
From now on they will appear soon after the run is uploaded!

Hope you enjoy using CodSpeed 😉

nstarman added a commit that referenced this pull request Jan 8, 2025
Co-authored-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v1.0.x on-merge: backport to versions/v1.0.x run-benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants