IECoreRenderMan Windows #6285
IECoreRenderMan Windows #6285
Conversation
bin/gaffer.cmd
Outdated
| ) else ( | ||
| set RMANTREE_STRIPPED=%RMANTREE% | ||
| ) | ||
| call :appendToPath "!RMANTREE_STRIPPED!" GAFFER_EXTENSION_PATHS |
There was a problem hiding this comment.
Is the usage of GAFFER_EXTENSION_PATHS what prompted your comment about spamming the environment a bit? Otherwise, the variables are the same as on Linux, correct?
There was a problem hiding this comment.
Yeah, it was the usage of GAFFER_EXTENSION_PATHS. It sets up a few paths like the glsl path that the Linux wrapper isn't setting, and I wasn't sure if that was done to keep those out of the environment variables when we know there won't be shaders and such there. Should be harmless enough?
But yes, otherwise my intention is to keep them the same on each platform.
There was a problem hiding this comment.
otherwise my intention is to keep them the same on each platform.
As an aside, I've been wondering how much of the separate Linux/Windows wrappers we could consolidate into the shared __gaffer.py. It seems like potentially quite a lot? Would be interested in any insights you might have there...
b14e529 to
dcb4e3f
Compare
This spams the environment variables a little bit, but I think this is better than needing `add_dll_directory()` in `IECoreRenderMan.__init__()` and it's the same as we're doing for Arnold.
We can't hold onto the `lightAttributes` longer than the renderer or it will attempt to delete a shader from a null Riley pointer when cleaning up the `lightAttributes`.
On Windows, we need to close the image before attempting to delete the temporary files in `tearDown()` so the OS will let them be deleted.
dcb4e3f to
62b96c1
Compare
|
Comments are addressed and I went ahead and squashed down. Ready for a new look! |
This adds the basics to get
IECoreRenderManrunning and passing tests on Windows. As with #6271, it doesn't run tests on CI yet. The use ofctypesin 8c1dff8 should be removable when we export at least one symbol from_IECoreRenderMan.pydPython module, so that Windows will actually import the symbols from theIECoreRenderMan.dllfile that registers the renderer.Checklist