InteractiveRenderTest improvements #6282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Renderer may choose not to sample all lights for each camera sample, so renders with a red and a green light may not converge quickly enough to satisfy the assertions in `testAddLight()`. Since we want to test the _addition_ of a light, and we have other tests for lights that exist at the start of the renderer, the simple fix is to just use one light for the test.
This is a tricky case in RenderMan so warrants some specific test coverage. The test also triggered a bug in 3Delight, in which the sampling of the light suffered badly after the shader was removed and replaced. It seemed that 3Delight had lost track of the fact that the surface was emissive and needed special sampling. Updating to the latest 3Delight version seems to fix that.
To avoid tripping up renderer backends that send multiple outputs to the same driver based on the name.
And implement muting for the 3Delight renderer backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the coverage provided by InteractiveRenderTest, which is used to test all the renderer backends in Gaffer. The motivation for this was to test problematic cases during the development of GafferRenderMan, but I'm breaking it off as a separate PR to aid digestion. This also adds support for light muting in GafferDelight, since it was required to get one of the new tests passing.