Refactor USDLayerWriter buildFilters() using parallelReduceLocations #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f5a02c to
1942585
Compare
1942585 to
a33e1a7
Compare
|
My benchmarks showed a 20x slowdown over the original. I think I've fixed that in the additional commit that I've pushed to this PR though - if that looks good to you then I'll squash and merge. |
|
LGTM |
a33e1a7 to
4008b88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was originally part of #6261, in order to test out the interface of the new SceneAlgo function.
Now that we seem happy with that interface, it makes sense to actually use this version. My understanding of this code isn't especially deep, so it would definitely be good to have John take a look at - plus it sounds like John has some performance tests he can run on it.