RenderMan transform, shader and geometry converters #6255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you haven't started to review this one yet @murraystevenson. I have a few changes that might be easier to look at fresh rather than as diffs. |
ed4c1a9 to
48099d0
Compare
|
OK, I've pushed the latest versions - should be good for review now. |
murraystevenson
approved these changes
Feb 7, 2025
src/IECoreRenderMan/Transform.h
Outdated
| struct AnimatedTransform : riley::Transform | ||
| { | ||
|
|
||
| /// Caution : `transformSamples` and `transformTimes` are referenced |
There was a problem hiding this comment.
transformTimes -> sampleTimes?
src/IECoreRenderMan/Transform.h
Outdated
| { | ||
|
|
||
| /// Caution : `transformSamples` and `transformTimes` are referenced | ||
| /// directly, and must live until the StaticTransform is passed to Riley. |
There was a problem hiding this comment.
StaticTransform -> AnimatedTransform?
src/IECoreRenderMan/MeshAlgo.cpp
Outdated
| vector<RtInt> tagArgCounts; | ||
| vector<RtInt> tagIntArgs; | ||
| vector<RtFloat> tagFloatArgs; | ||
| vector<RtToken> tagStringArgs; |
There was a problem hiding this comment.
tagStringArgs appears to be unused?
These make it easy to convert a transform in Imath/Gaffer format to a `riley::Transform` to be used with the RenderMan API.
This will be used to convert shaders in the upcoming RenderMan renderer backend.
This will provide geometry conversion services for the upcoming renderer backend.
48099d0 to
146a375
Compare
Thanks for spotting those - I've squashed the fixes in and am merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will do much of the heavy lifting of the upcoming RenderMan backend. For the most part the conversions are all fairly straightforward, and the APIs should be fairly familiar due to being modelled closely on IECoreArnold. Things will get more interesting in the next PR which will actually introduce the Renderer subclass, where things get a little more involved.