ShaderView : Scope correct context when computing shader #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was just my guess, given that I wasn't seeing the issue when viewing 3d scene data. |
|
Are you happy for this to be in 1.3 only, or do you need it in 1.2? I didn't actually check the repro in 1.2 since you reported against 1.3.10... |
|
It's fine to have it for 1.3 only, since we have workarounds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5654.
@ivanimanishi, I believe I have fixed the exact issue corresponding to your repro steps, but that was specific to the ShaderView, and in your issue description you talk more generally about the ImageView. I couldn't reproduce a similar issue in the ImageView, but if you know of one then let me know and I'll fix that too...