Arnold Minor Aov Fixes #5645
Merged
Arnold Minor Aov Fixes #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Arnold gives a less informative error, either like: 00:00:00 379MB WARNING | [aov] unable to parse output line, found wrong number of tokens Or even worse, sometimes the parser gets confused and starts parsing things wrong, resulting in: 00:00:00 380MB ERROR | [aov] output references a non-camera node: someData ( Where the data was declared as "color someData" )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of little things from discussion on the discord.
Added normal and depth AOVs to the presets list ... do these names seem right, or should they be N and Z?
In the output images, the depth channel is named Z, which is what everyone should expect. The normal channels are named RGB, which I think is also what people expect - I'm not aware of any custom convention for the axis names.
I've also added in an exception if the output name contains a space - this prevents getting a much more confusing error from Arnold. This is turned into a warning upstream ... I wasn't sure whether this is worth halting the render for, but this behaviour just matches how we handle outputs with invalid driver types.