Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardGraphLayout improvements #5626

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

johnhaddon
Copy link
Member

This improves the logic used to connect newly-created nodes to the currently selected nodes in the GraphEditor. It avoids the creation of intersecting connections, and prefers to connect plugs that have opposing tangents. The first makes the creation of Group nodes much less tedious, and the second is necessary for an upcoming Dispatcher feature.

image

@johnhaddon johnhaddon self-assigned this Jan 15, 2024
@johnhaddon johnhaddon changed the title Standard graph layout improvements StandardGraphLayout improvements Jan 16, 2024
Copy link
Contributor

@murraystevenson murraystevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The avoidance of creating intersecting connections is great, and the new behaviour of preferring connections made to plugs with opposing tangents makes sense in the context of the Dispatcher changes and doesn't seem problematic in the general case...

@johnhaddon johnhaddon force-pushed the standardGraphLayoutImprovements branch from 4f93035 to 6087989 Compare January 18, 2024 09:14
@johnhaddon
Copy link
Member Author

Rebased to fix merge conflict, and merging...

@johnhaddon johnhaddon merged commit 8b6d407 into GafferHQ:main Jan 18, 2024
4 checks passed
@johnhaddon johnhaddon deleted the standardGraphLayoutImprovements branch March 15, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants