Layouts : Improve loading of layouts with unavailable editors #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses proxies for missing modules and editors, so we can load the rest of the layout successfully. The proxy editor appears as a tab in the UI as normal but with an "editor not available" label rather than the usual contents. The proxy can also be resaved into a new layout and then be loaded as the _real_ editor later when that becomes available. This will allow us to load layouts from Gaffer 1.4 in 1.3, even if they include an ImageInspector or LocalJobs panel. Saving the layout in 1.3 and reloading it in 1.4 will even preserve the new editors.
This was referenced Jan 9, 2024
murraystevenson
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Nice one! While a little tricky, this does seem a lot more palatable than the blunt instrument approach of versioning the preferences and its potential proliferation of startup files...
I think the only thing I've spotted that we lose out on here is the 'nodeSet' pinning/following state of an unavailable editor is lost when the layout is resaved in 1.3. But that seems a minor quibble given the solution to broken layouts that this provides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses proxies for missing modules and editors, so we can load the rest of the layout successfully. The proxy editor appears as a tab in the UI as normal but with an "editor not available" label rather than the usual contents. The proxy can also be resaved into a new layout and then be loaded as the real editor later when that becomes available.
This will allow us to load layouts from Gaffer 1.4 in 1.3, even if they include an ImageInspector or LocalJobs panel. Saving the layout in 1.3 and reloading it in 1.4 will even preserve the new editors.