Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3Delight auto NSI export format based on file extension #5614

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

gkocov
Copy link
Collaborator

@gkocov gkocov commented Jan 7, 2024

Generally describe what this PR will do, and why it is needed

  • DelightRender node NSI scene description export format is based on file extension - .nsi for binary and .nsia for ASCII

Breaking changes

  • .nsi file extension export is now binary, while previously it was ASCII (not sure if this applicable since it's not a API/ABI change, but wanted to list it just in case)

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@johnhaddon
Copy link
Member

Thanks Goran! Again, I've rebased to fix the conflict in Changes.md (they crop up a lot, because most PRs edit that file). Merging...

@johnhaddon johnhaddon merged commit bf9827d into GafferHQ:main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants