Skip to content

Commit

Permalink
CIS: Change the parsing test to test against computed value.
Browse files Browse the repository at this point in the history
This patch changes the "reference" box to use the computed value of
width, instead of the used value.

From: https://drafts.csswg.org/cssom/#resolved-value-special-case-property-like-height

```
If the property applies to the element or pseudo-element and the resolved value
of the display property is not none or contents, then the resolved value is the
used value. Otherwise the resolved value is the computed value.
```

Since we're testing the computed value of contain-intrinsic-size, we
should compare it against a computed value of width in the reference.

R=futhark@chromium.org

Change-Id: I9dc3376ca6c3c41ab835251e29ec639a7c1336cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4442948
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1132453}
  • Loading branch information
vmpstr authored and pull[bot] committed Jan 15, 2024
1 parent 1977bcf commit 4c01c08
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/css/support/computed-testcommon.js"></script>
<style>
#scratch { display: none }
</style>
</head>
<body>
<div id=target></div>
Expand Down

0 comments on commit 4c01c08

Please sign in to comment.