-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Code and Artifact Directory Restructure #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ohsh6o
changed the title
Source Code and Artifactor Directory Restructure
Source Code and Artifact Directory Restructure
Jul 16, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ohsh6o
force-pushed
the
restructure-validations-code
branch
from
July 16, 2021 16:42
1448f32
to
befd500
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ohsh6o
commented
Jul 16, 2021
ohsh6o
commented
Jul 16, 2021
This comment has been minimized.
This comment has been minimized.
Word to the wise, we stick with this until we understand what is happening with npm. https://github.com/18F/fedramp-automation/blob/1bf434da9dd53a7f54540fa6e54e670ca7597dde/resources/validations/ui/package-lock.json.
This comment has been minimized.
This comment has been minimized.
danielnaab
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minus whatever you need to do on the Github Actions, looks great.
Co-authored-by: Daniel Naab <dnaab@flexion.us>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 20, 2021
Closed
danielnaab
added a commit
that referenced
this pull request
Jul 29, 2021
Merge GSA/master to 18F/develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have a collection of source code for OSCAL content and validation tools, begin better directory structure and organization to clarify what is source material & code versus what are resulting built artifacts.
Done in coordination with the 10x ASAP Team for 18F#131.