-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert short code to drupal equivalent #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grated it into the convert text form.
…e could use it. Please enter the commit message for your changes. Lines starting
40e59c4
to
bf94b72
Compare
@mattsqd can you resolve the conflicts so I can test? |
…-short-code-to-drupal # Conflicts: # composer.lock # composer.log # web/modules/custom/convert_text/src/ConvertText.php # web/modules/custom/default_content_config/content/node/fd186b65-70b7-499a-a9be-050562561209.yml
…nkItMarkup uses the Html class to load and serialize.
…reate ul, not a entity embed. Changed the format of various entity embeds to match the new specs. Support featured resource external. Implemented equivalent for quote block.
…-short-code-to-drupal
@rayestrada the conflicts have been fixed and this is ready to test again. |
omerida
reviewed
Feb 19, 2025
…-short-code-to-drupal # Conflicts: # composer.log
omerida
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used convert text with the sample page and then took that HTML and created a page. Shortcodes looked correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
DIGITAL-41
Purpose
When the 'content' of the markdown files are migrated, they contain shortcode tags that look like
{{< name >}}
. Each of these has been migrated into a corresponding Drupal functionality. Most are embedded content entities, but some are media and, some are just simple things like links. This functionality shows how we can send this text through Drupal and replace it.Includes the following PRs that must be merged first
Deployment and testing
Local Setup
lando rebuild -y && lando si
QA/Testing instructions
We've made a testing page in Hugo that showcases all the short codes that we are migrating. You can find that file here.
What you will want to do is take the contents of that file and paste it into http://digitalgov.lndo.site/admin/convert-text with 'Fields like body that summary or body that will contain HTML and Markdown' selected. This will mimic the same thing that will happen during the migration, where every field with shortcodes in it will be processed with this functionality.
What should you see?
Take the text in 'Converted Text' and paste it into the 'Source' of the body of a basic page. You should see something VERY similar to http://digitalgov.lndo.site/short-code-test-page. Note that somethings require other migrations to be run, so there is only placeholders.
The page should look the same as the demo except one's that require place holders.
Checklist for the Developer
Checklist for the Peer Reviewers