Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non paginated decorator wrapper #146

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Non paginated decorator wrapper #146

merged 3 commits into from
Feb 12, 2025

Conversation

btylerburton
Copy link
Contributor

Adds a new decorator and usage pattern to allow non-paginated interface queries to access the count decorator...

Pull Request

Related to [LINK TO ISSUE]

About

PR TASKS

  • Code well documented
  • Tests written, run and passed
  • Files linted

@btylerburton btylerburton force-pushed the give-more-count-decorator branch from c1b53fa to b690eea Compare February 12, 2025 15:42
neilmb
neilmb approved these changes Feb 12, 2025
View reviewed changes
Copy link

@neilmb neilmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks fine, but I'm just trying to understand the usage pattern of the count=True argument.

tests/integration/database/test_db.py Show resolved Hide resolved
@btylerburton btylerburton merged commit 1f3bf48 into main Feb 12, 2025
4 checks passed
@btylerburton btylerburton deleted the give-more-count-decorator branch February 12, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilmb neilmb neilmb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btylerburton @neilmb