Redirect Root Route for Datagov Harvest Admin #141
+631
−540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7798e1 to
3e64623
Compare
3e64623 to
f6b9d6b
Compare
f6b9d6b to
a23beed
Compare
a23beed to
49bed0c
Compare
neilmb
previously approved these changes
Feb 12, 2025
app/routes.py
Outdated
| # TODO: wire in paginated jobs htmx refresh ui & route | ||
| jobs = db.pget_harvest_jobs( | ||
| paginate=False, facets=f"harvest_source_id = '{source.id}'" | ||
| ) | ||
| next_job = "N/A" | ||
| if len(jobs): |
There was a problem hiding this comment.
comment (non-blocking): I think that the most idiomatic version of this might be if jobs:, or maybe if len(jobs) > 0, but it's also fine as-is.
app/routes.py
Outdated
| # TODO: wire in paginated jobs htmx refresh ui & route | ||
| jobs = db.pget_harvest_jobs( | ||
| paginate=False, facets=f"harvest_source_id = '{source.id}'" | ||
| ) | ||
| next_job = "N/A" | ||
| if len(jobs): | ||
| last_job = jobs[len(jobs) - 1] |
There was a problem hiding this comment.
comment (non-blocking): More idioms, negative indexes count from the end so last_job = jobs[-1] works the same as what you have here.
cmhedrickREI
previously approved these changes
Feb 12, 2025
409f89f to
b054910
Compare
b054910 to
2445239
Compare
2445239 to
1d44144
Compare
1d44144 to
fb1e624
Compare
redirects to all orgs page on load; udpates harvest source page with feedback changes; updates fixtures to have better jobs data; fixes broken tests; lint
cleans up metrics route code; fixes issue with pagination numbers in pagination module; makes pagination per_page count a kwarg; removes sort functionality from tables as it breaks with htmx updates and is not super useful
calculates count using new count decorator
fb1e624 to
f46b266
Compare
2aa3287 to
33d598c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related to:
About
Also:
PR TASKS