Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug when adding new matter #18

Closed
wants to merge 8 commits into from
Closed

Fix the bug when adding new matter #18

wants to merge 8 commits into from

Conversation

AreefW
Copy link
Collaborator

@AreefW AreefW commented Feb 13, 2025

The code breaks when adding new matter in Source/Matter.

To solve this bug, each matter type should be inside its own subdirectory. Therefore Source/Matter/ScalarField has been added. The path to a specific matter type has to be specified in GNUmakefile for each example.

These changes make it easier and cleaner to add new matter to Source and the use in each example.

@AreefW AreefW linked an issue Feb 13, 2025 that may be closed by this pull request
@AreefW AreefW marked this pull request as ready for review February 13, 2025 15:28
@AreefW AreefW requested a review from SamuelBrady February 13, 2025 15:28
@AreefW AreefW closed this Feb 13, 2025
@AreefW AreefW deleted the bugfix/matter branch February 13, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants