Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to run development environment on windows #3324

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 9, 2022

Tested on a windows vm with plain cmd.exe

Uses a code snippet found in viewstools/yarn-workspaces-cra-crna#28 which manually runs yarn via a spawned process, which replaces the 'get-yarn-workspaces' dependency, which assumed forward slashes

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 9, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #3324 (d14ef05) into main (bc6adcb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3324   +/-   ##
=======================================
  Coverage   59.50%   59.50%           
=======================================
  Files         736      736           
  Lines       28999    28999           
  Branches     7017     7017           
=======================================
  Hits        17257    17257           
  Misses      11496    11496           
  Partials      246      246           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 8c2f645 into main Nov 10, 2022
@cmdcolin cmdcolin deleted the fix_windows branch November 10, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants