Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GEOSadas CI Build (ifort only) #975

Merged
merged 17 commits into from
Feb 8, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Aug 17, 2021

Description

This adds a GEOSadas CI build in MAPL. Only with ifort.

NOTE: This uses the develop branch of GEOSadas, then checks out the develop branch of ESMA_cmake (because I had to do that in my nightly tests) and then it checks out the feature/mathomp4/add-extended-source-prepbykx branch of GEOSana_GridComp until GEOS-ESM/GEOSana_GridComp#86 is merged into a tag of GEOSana_GridComp and then that tag is in GEOSadas's components.yaml.

So, it's fragile.

Related Issue

Motivation and Context

Makes sure we can build GEOSadas with MAPL development!

How Has This Been Tested?

Well, I was able to build by hand on Discover...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Aug 17, 2021
@mathomp4
Copy link
Member Author

mathomp4 commented Nov 1, 2021

@mathomp4 Try to make it so the ADAS test is only triggered on PRs to main.

@mathomp4
Copy link
Member Author

mathomp4 commented Nov 1, 2021

Welp, MAPL develop (and even main) and GEOSadas have diverged to far for this to work at the moment. I think when the new ADAS is released, we have a chance. (Or I just need to do some mepo magic in the CI. Not hard.)

@mathomp4
Copy link
Member Author

mathomp4 commented Feb 7, 2022

Okay. I'm trying this now with some of the fancy magic in the GEOS Orb. I'm trying to checkout the develop branch of GEOSadas and then build that. Let's see!

@mathomp4 mathomp4 marked this pull request as ready for review February 7, 2022 20:21
@mathomp4 mathomp4 requested a review from a team as a code owner February 7, 2022 20:21
tclune
tclune previously approved these changes Feb 8, 2022
@mathomp4 mathomp4 merged commit 8e5b705 into develop Feb 8, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/enable-adas-ci branch February 8, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants