Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Updates to use fArgParse in MAPL3 #1960

Merged
merged 7 commits into from
Jun 8, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Feb 9, 2023

Description

This PR updates MAPL3 to use fArgParse exclusively in an effort to remove FLAP.

I think we still have a few things to check off before pulling this in:

  • Run GEOSgcm.x
  • Have @bena-nasa test ExtDataDriver.x
  • Have @JulesKouatchou test pfio_MAPL_demo.x
  • Move to Baselibs 7.10.0 (to fix annoying ArgParser print)
  • Work with @tclune on fixing the "extra options" bit in MAPL_demo_fargparse.F90

Related Issue

closes #1756

Motivation and Context

We want to deprecate FLAP and move to fArgParse (and maybe even remove both, but start with FLAP)

How Has This Been Tested?

I ran GEOS, it works.

I ran MAPL_demo_fargparse.x and it doesn't

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 9, 2023
@mathomp4 mathomp4 self-assigned this Feb 9, 2023
@mathomp4
Copy link
Member Author

mathomp4 commented Jun 8, 2023

Superseded by #2178

@mathomp4 mathomp4 merged commit 26e0967 into release/MAPL-v3 Jun 8, 2023
@mathomp4 mathomp4 deleted the feature/mathomp4/fix-mapl3-fargparse branch July 3, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant