Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable use of multi group server in ExtDataDriver.x #1934

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

bena-nasa
Copy link
Collaborator

Yonggang was trying to use ExtDataDriver.x and I said, it should work with the o-server on dedicated resources (aka the multi group server). Famous last words, it was just broken. I had not synced up changes from MAPL_Cap to reflect changes in the o-server initialization and there was a barrier that should not have been there in my code.

This fixes that. Made it a hotfix since it was a bug.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

…DataDriver.x this fixes, needed to be synced with MAPL_Cap
@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Jan 18, 2023
@bena-nasa bena-nasa requested a review from a team as a code owner January 18, 2023 15:07
atrayano
atrayano previously approved these changes Jan 18, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner January 18, 2023 19:51
@mathomp4 mathomp4 requested a review from atrayano January 18, 2023 19:51
@mathomp4
Copy link
Member

Since this is a hotfix, I've pushed a change to get the CMake ready for that. Might need to re-approve @atrayano

@mathomp4 mathomp4 merged commit cfad78e into main Jan 19, 2023
@mathomp4 mathomp4 deleted the hotfix/bmauer/fix_extdatadriver_with_dedicted_oserver branch January 19, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants