-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stricter debugging flags when building MAPL as Debug #1871
Add stricter debugging flags when building MAPL as Debug #1871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has got to be a cleaner way to add a flag. When you have a chance you need to remind me why de-duplication is involved.
The reason is that we have flags like:
and when I tried it out, many of the CMake methods made them into:
per CMake:
I suppose my question was, should I "hide" this in a file. In the end, probably not worth it... |
Description
This PR adds some CMake code to apply additional flags when building MAPL as Debug.
This also updates the ESMA_cmake in the
components.yaml
to 3.22.0 which defines these new flags. Note that if you don't have this version of ESMA_cmake, then it's just a no-op as all the variables are empty.Related Issue
Motivation and Context
The extra flags are good since Intel is often "too loose" and at least it will throw a lot of warnings and not allow things like
if(integer)
or setting a logical to an integer.How Has This Been Tested?
Built and ran GEOS. If it builds...that's good enough!
I've also checked and the flags only appear if Debug.
Types of changes
Checklist: