Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 4d integer reading subroutine to formatter #1838

Merged
merged 3 commits into from
Dec 2, 2022
Merged

add 4d integer reading subroutine to formatter #1838

merged 3 commits into from
Dec 2, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Dec 1, 2022 •
edited
Loading

Added subroutine that reads 4d integer to formatter

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 1, 2022
@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner December 1, 2022 13:48
@mathomp4
Copy link
Member

mathomp4 commented Dec 1, 2022

Wow. 4d!

mathomp4
mathomp4 reviewed Dec 1, 2022
View reviewed changes
@mathomp4 mathomp4 self-requested a review December 2, 2022 18:15
@mathomp4 mathomp4 merged commit 7e1c7e8 into develop Dec 2, 2022
@mathomp4 mathomp4 deleted the feature/wjiang/reading_4d_integer branch December 2, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiyuan-jiang @mathomp4