Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check userRC in MAPL_GenericInitialize #1684

Merged
merged 1 commit into from
Sep 22, 2022
Merged

check userRC in MAPL_GenericInitialize #1684

merged 1 commit into from
Sep 22, 2022

Conversation

bena-nasa
Copy link
Collaborator

Really trivial change, we were not checking the userRC from the ESMF_GridCompInitialize in MAPL_GenericInitialize

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Sep 22, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner September 22, 2022 19:07
tclune
tclune approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this does not fix the other issue though?

@bena-nasa
Copy link
Collaborator Author

I assume that this does not fix the other issue though?

No, but we are missing it, and when Matt saw the original problem it let the code run longer than it should have so I thought lets just get it in there.

@bena-nasa bena-nasa merged commit 10ed93e into develop Sep 22, 2022
@bena-nasa bena-nasa deleted the feature/bmauer/check_genericinit_userrc branch September 22, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bena-nasa @tclune