Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/wjiang/exit after connected #1326

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Feature/wjiang/exit after connected #1326

merged 3 commits into from
Jan 28, 2022

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented Jan 28, 2022 •
edited
Loading

When connected is sure, exit without continue to improve performance

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@weiyuan-jiang weiyuan-jiang requested a review from a team as a code owner January 28, 2022 19:33
@weiyuan-jiang weiyuan-jiang added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jan 28, 2022
@weiyuan-jiang
Copy link
Contributor Author

@atrayano , Please verify that my understanding is correct.

mathomp4
mathomp4 reviewed Jan 28, 2022
View reviewed changes
@weiyuan-jiang @mathomp4
Update CHANGELOG.md
1269f29 
Co-authored-by: Matthew Thompson <matthew.thompson@nasa.gov>
atrayano
atrayano approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@atrayano atrayano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I am nearly 100% sure that the logic is still correct!

@atrayano atrayano merged commit 852cd94 into develop Jan 28, 2022
@atrayano atrayano deleted the feature/wjiang/exit_after_connected branch January 28, 2022 20:23
@mathomp4 mathomp4 mentioned this pull request Jan 31, 2022
Closed
mathomp4 added a commit that referenced this pull request Jan 31, 2022
@mathomp4
Revert "Merge pull request #1326 from GEOS-ESM/feature/wjiang/exit_af…
c571f30 
…ter_connected"

This reverts commit 852cd94, reversing
changes made to 96f4916.
@mathomp4 mathomp4 mentioned this pull request Jan 31, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 left review comments

@atrayano atrayano atrayano approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiyuan-jiang @mathomp4 @atrayano