Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Ninja presets #1321

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix issue with Ninja presets #1321

merged 1 commit into from
Jan 27, 2022

Conversation

mathomp4
Copy link
Member

Description

I made some mistakes in the CMakePresets.json when running with Ninja generator. I mean, things worked before, just incorrectly. This fixes it.

(Of course, this is technically a hotfix as the bug is in main but no one but me cares about this. 😄 )

Related Issue

Motivation and Context

I like using CMake presets. This fixes it.

How Has This Been Tested?

Things work with this fix and don't without it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jan 27, 2022
@mathomp4 mathomp4 self-assigned this Jan 27, 2022
@mathomp4 mathomp4 marked this pull request as ready for review January 27, 2022 15:56
@mathomp4 mathomp4 requested a review from a team as a code owner January 27, 2022 15:56
@tclune tclune merged commit 96f4916 into develop Jan 27, 2022
@tclune tclune deleted the feature/mathomp4/fix-cmakepresets-mapl branch January 27, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune