Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed optional parameter TO_NAME in AddExportFromChild for GOC… #1123

Merged
merged 6 commits into from
Oct 22, 2021

Conversation

amdasilva
Copy link
Contributor

…ART-2G

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@amdasilva amdasilva added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Oct 21, 2021
@amdasilva amdasilva requested a review from a team as a code owner October 21, 2021 23:50
Copy link
Contributor

@atrayano atrayano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amdasilva There is a syntax error at line 4921 of generic/MAPL_Generic.F90. Could you please change the ":" symbol to "!"

tclune
tclune previously approved these changes Oct 22, 2021
@tclune
Copy link
Collaborator

tclune commented Oct 22, 2021

@amdasilva There is a syntax error at line 4921 of generic/MAPL_Generic.F90. Could you please change the ":" symbol to "!"

It was at a different line number, but I've fixed it.

Comment on lines +3377 to +3385
subroutine MAPL_StateAddExportSpecFrmChld ( GC, SHORT_NAME, CHILD_ID, RC, TO_NAME )

!ARGUMENTS:
type(ESMF_GridComp), intent(INOUT) :: GC
character (len=*) , intent(IN) :: SHORT_NAME
character (len=*) , intent(IN) :: SHORT_NAME ! NAME in CHILD
integer , intent(IN) :: CHILD_ID
integer , optional , intent(OUT) :: RC
character (len=*), optional, intent(IN) :: TO_NAME ! NAME to appear is EXPORT;
! default is SHORT_NAME
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to change the order here too, then somone must find all external calls and make sure they already have RC=.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh. Smart. Yeah, probably better not to break backwards compatibility until we know where they all are...and I have no idea what this call is actually called in GEOS. :)

@tclune tclune self-requested a review October 22, 2021 12:59
@mathomp4 mathomp4 requested review from mathomp4 and atrayano October 22, 2021 13:42
@mathomp4 mathomp4 dismissed atrayano’s stale review October 22, 2021 13:43

Bad comment was corrected

@mathomp4
Copy link
Member

We are duplicating the code here in #1125 because of CI issues that needs solved with multi-repo clones

@mathomp4 mathomp4 merged commit 72bec82 into develop Oct 22, 2021
@mathomp4 mathomp4 deleted the feature/#328/geos-v10.17.6/gocart2g/new-extdata branch January 4, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants