-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed optional parameter TO_NAME in AddExportFromChild for GOC… #1123
Exposed optional parameter TO_NAME in AddExportFromChild for GOC… #1123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amdasilva There is a syntax error at line 4921 of generic/MAPL_Generic.F90. Could you please change the ":" symbol to "!"
It was at a different line number, but I've fixed it. |
subroutine MAPL_StateAddExportSpecFrmChld ( GC, SHORT_NAME, CHILD_ID, RC, TO_NAME ) | ||
|
||
!ARGUMENTS: | ||
type(ESMF_GridComp), intent(INOUT) :: GC | ||
character (len=*) , intent(IN) :: SHORT_NAME | ||
character (len=*) , intent(IN) :: SHORT_NAME ! NAME in CHILD | ||
integer , intent(IN) :: CHILD_ID | ||
integer , optional , intent(OUT) :: RC | ||
character (len=*), optional, intent(IN) :: TO_NAME ! NAME to appear is EXPORT; | ||
! default is SHORT_NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to change the order here too, then somone must find all external calls and make sure they already have RC=.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh. Smart. Yeah, probably better not to break backwards compatibility until we know where they all are...and I have no idea what this call is actually called in GEOS. :)
We are duplicating the code here in #1125 because of CI issues that needs solved with multi-repo clones |
…ART-2G
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: