Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History: Detemplate %d in long name #1878

Closed
mathomp4 opened this issue Dec 14, 2022 · 2 comments
Closed

History: Detemplate %d in long name #1878

mathomp4 opened this issue Dec 14, 2022 · 2 comments
Assignees
Labels
❗ High Priority This is a high priority PR

Comments

@mathomp4
Copy link
Member

mathomp4 commented Dec 14, 2022

Per @amdasilva, he would like the %d seen in the ACG here:

image

to be expanded to the Bin Number when the fields are split on bins:

Now, when history expands the bin number for the ungridded dimension, it is supposed to expand the %d above with the bin number; right now, I believe the output file shows “%d” which is not right. Another possibility is to omit the “(Bin %d)” from the rc file and have history add (Bin 001), (Bin 002), etc as it flattens out the ungridded dimension. Atanas knows what I am talking about.

Note to @atrayano, I guess if only one bin just use Bin 001??

@mathomp4 mathomp4 added the ❗ High Priority This is a high priority PR label Dec 14, 2022
@tclune
Copy link
Collaborator

tclune commented Dec 14, 2022

I want to be careful here. "Bin" has a strong meaning in GOCART but another component might want to use some other parameter for expansion. So it might be best to have a slightly more complex notation that can be more clearly used in other contexts.

@tclune
Copy link
Collaborator

tclune commented Dec 14, 2022

Never mind. The parameter is evaluated for the "split" dimension.

So now my concern is that we want something that could work in some future case with 2 ungridded dims.

atrayano added a commit that referenced this issue Jan 4, 2023
…me_template

Fixes #1878. The adds ability to expand %d in the long name, when we …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ High Priority This is a high priority PR
Projects
None yet
Development

No branches or pull requests

4 participants