Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ExtData2G, do not check for file file variable if collection is /dev/null #1657

Closed
bena-nasa opened this issue Sep 6, 2022 · 0 comments · Fixed by #1659
Closed

In ExtData2G, do not check for file file variable if collection is /dev/null #1657

bena-nasa opened this issue Sep 6, 2022 · 0 comments · Fixed by #1659
Assignees

Comments

@bena-nasa
Copy link
Collaborator

I checked out main of the GEOSgcm fixture as I saw some of the repos were moved to newer version and did my usual does ExtData2G still work test. I found it was failing as some new variables were added to the TR grid comps ExtData files that are set to /dev/null for now. But those rules did not have a "variable" keyword as that's not needed in this case but the lack of this was causing a crash.
I went back and looked at my test case 19 that tests /dev/null and indeed it looks like I just took an existing file and changed the collection to /dev/null and left the variable there so that's why my test case 19 was working. But when I looked at the logic in ExtData2G, it was a bit screwy in that if the collection was /dev/null I still insisted the variable keyword be there. This is not necessary in that case and should be fixed.

@bena-nasa bena-nasa self-assigned this Sep 6, 2022
bena-nasa added a commit that referenced this issue Sep 6, 2022
@bena-nasa bena-nasa mentioned this issue Sep 6, 2022
7 tasks
@mathomp4 mathomp4 linked a pull request Sep 7, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant