Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change naming convention for split fields in HISTORY #1363

Closed
atrayano opened this issue Feb 15, 2022 · 0 comments
Closed

Change naming convention for split fields in HISTORY #1363

atrayano opened this issue Feb 15, 2022 · 0 comments
Assignees
@atrayano

Comments

@atrayano
Copy link
Contributor

The current implementation of generating names for the split fields cannot produce in certain situations the desired outcome (i.e. preserve the file spec). The main issue is that if it is desired to generate a split name is identical to the original un-split, this would create a conflict due to duplicates.
@atrayano atrayano self-assigned this Feb 15, 2022
atrayano added a commit that referenced this issue Feb 18, 2022
@atrayano
Fixes #1363. Moved the split field logic to where we
fc5e540 
put the fields in containers for averaging and/or regridding
@atrayano atrayano mentioned this issue Feb 22, 2022
Merged
7 tasks
atrayano added a commit that referenced this issue Feb 22, 2022
@atrayano
Fixes #1363. Fixed a bug related to an optional argument not passed in
04888c8
mathomp4 added a commit that referenced this issue Feb 23, 2022
@mathomp4
Merge pull request #1364 from GEOS-ESM/feature/atrayano/#1363_split_f…
87af383 
…ield

Fixes #1363. The main change to create a copy of the exports, so we c…
@tclune tclune closed this as completed in e45e7da Feb 23, 2022
@github-actions github-actions bot mentioned this issue Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atrayano atrayano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atrayano