Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new History metadata configurable #1282

Closed
mathomp4 opened this issue Jan 6, 2022 · 3 comments
Closed

Make new History metadata configurable #1282

mathomp4 opened this issue Jan 6, 2022 · 3 comments
Assignees
Labels
🎁 New Feature This is a new feature

Comments

@mathomp4
Copy link
Member

mathomp4 commented Jan 6, 2022

Due to the changes in MAPL 2.15.1 (see #1271), we now have "hard-coded" into the global metadata of MAPL History output:

:Contact = "http://gmao.gsfc.nasa.gov" ;
:Institution = "NASA Global Modeling and Assimilation Office" ;

While these are good defaults for the majority of MAPL users, some of our other colleagues at Harvard (@lizziel) and NOAA (@rmontuoro) and even non-GMAO NASA users (@mmanyin) could use MAPL for History output and would probably enjoy not having to do an extra ncatted call to change this.

So, let us allow the ability to change these values inside HISTORY.rc (and upcoming history.yaml) files a la:

INSTITUTION: "Yoyodyne Propulsion Systems"
CONTACT: "Lord John Whorfin"

We also have:

:Comment = "NetCDF-4" ;

Whatever needs to be done for the Contact and Institution can probably be extended to the Comment field as well. Might as well let users make whatever comments they'd like to as well.

@mathomp4 mathomp4 added the 🎁 New Feature This is a new feature label Jan 6, 2022
@mathomp4
Copy link
Member Author

mathomp4 commented Jan 6, 2022

Actually, I'm not sure if spaces are allowed in ESMF_Config objects (@bena-nasa, @atrayano or @tclune might know). Might be nice to have some sort of "translate underscores to spaces" sort of capability with this?

@atrayano
Copy link
Contributor

atrayano commented Jan 6, 2022

Spaces are allowed in ESMF_Config and normally they are ignored. But in a quoted string they are preserved and kept

@mathomp4
Copy link
Member Author

mathomp4 commented Jan 6, 2022

Spaces are allowed in ESMF_Config and normally they are ignored. But in a quoted string they are preserved and kept

Ahhh. And you are correct, @atrayano! I just just hacked in a config object in a random GC to test and:

INSTITUTION: Yoyodyne Propulsion Systems

printed out:

MATMAT INSTITUTION: Yoyodyne

but:

INSTITUTION: "Yoyodyne Propulsion Systems"

gave me:

MATMAT INSTITUTION: Yoyodyne Propulsion Systems

I learned some ESMF today! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 New Feature This is a new feature
Projects
None yet
Development

No branches or pull requests

3 participants