Make CICE4 built as a shared library #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
sanAkel
previously approved these changes
Apr 14, 2023
|
@sdrabenh I updated the CHANGELOG here to reflect the 1.9.0 release so that when this gets in, it'll look complete. |
sanAkel
approved these changes
May 23, 2023
sdrabenh
approved these changes
Jun 5, 2023
sanAkel
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changed static build of CICE4 into a shared library (dso). This is done to prepare for upcoming CICE6 integration. CICE4 and CICE6 share many names which makes it unfeasible to build both into statically linked objects (name conflicts will occur). This issue is similar to MOM5/MOM6 build in GEOS.
Tests have been done with static and dso CICE4 build and both AMIP and coupled have zero-diff results.