updates for integrated setup and coupled run of LADAS #81
Conversation
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
There was a problem hiding this comment.
@saraqzhang : I added a few inline comments that probably require further discussion at our next tag-up
GEOSldas_App/ldas_setup
Outdated
| @@ -153,6 +154,9 @@ class LDASsetup: | |||
|
|
|||
| for key in rqdExeInpKeys : | |||
| assert key in self.rqdExeInp,' "%s" is required in the input file %s' % (key,self.exeinpfile) | |||
| if cmdLineArgs['nymdb' ] != 'None' : | |||
| self.date = f"{self.nymdb} 210000" | |||
There was a problem hiding this comment.
I think we will need to pass in HHMMSS as well, or at least HH. Should this ever run in FP, we cannot hardwire 21z.
GEOSldas_App/ldas_setup
Outdated
| self.adas_expdir = os.path.dirname(self.exphome) | ||
| self.rqdExeInp[ 'ADAS_EXPDIR'] = self.adas_expdir | ||
| self.adas_expid = os.path.basename(self.adas_expdir) | ||
| self.rqdExeInp[ 'MET_TAG' ] = self.adas_expid + '__Nx+-' |
There was a problem hiding this comment.
Do we really want to edit ldas_setup with '__Nx+-' knowing that this is already being changed? Can we go straight to the new "bkg" location of the lfo files?
There was a problem hiding this comment.
I will leave Nx+- option in till we get bkg updates in and tested
GEOSldas_App/ldas_setup
Outdated
| for line in fileinput.input(tmprcfile,inplace=True): | ||
| print (line.rstrip().replace("# 'catch_progn_incr'"," 'catch_progn_incr'")) | ||
| for line in fileinput.input(tmprcfile,inplace=True): | ||
| print (line.rstrip().replace('catch_progn_incr.ref_time: 000000,','catch_progn_incr.ref_time: 013000,')) | ||
| for line in fileinput.input(tmprcfile,inplace=True): | ||
| print (line.rstrip().replace("'SMAP_L4_SM_gph'","# 'SMAP_L4_SM_gph'")) | ||
|
|
There was a problem hiding this comment.
It might make more sense to add a new template of GEOSldas_HIST.rc that is specific to the LADAS, rather than edit GEOSldas_HIST.rc in this way
There was a problem hiding this comment.
can we add a new template for central and one for atmens in GEOSldas_App/ , so that they will be installed along with GEOSldas_HIST.rc in install-SLES15/etc/ by adas build.
There was a problem hiding this comment.
Yes, I assume we need separate templates for the central and atmens system components. In the latter, we probably need to hardwire the number of atm ens members, which isn't great but probably unavoidable.
GEOSldas_App/ldas_setup
Outdated
| @@ -1710,6 +1728,11 @@ def parseCmdLine(): | |||
| help='replace computing/sponsor account in batinp file', | |||
| type=str, default='None' | |||
| ) | |||
| p_setup.add_argument( | |||
| '--nymdb', | |||
| help='replace BEG_DATE in expinp file ', | |||
There was a problem hiding this comment.
Not sure I understand the comment. Should this read:
'replaces BEG_DATE in expinp file' ?? (without the s in "replaces", it reads like an instruction, when I think this help text describes the effect of specifying --nymdb
Also, it looks like there's a typo: "exeinp" instead of "expinp"?
There was a problem hiding this comment.
spot on. maybe we can say "supersedes BEG_DATE in expinp file "
GEOSldas_App/ldas_setup
Outdated
| self.rqdExeInp[ 'EXP_ID' ] = self.adas_expid + '_LDAS' | ||
| if self.ladas_coupling == 2: | ||
| self.rqdExeInp[ 'EXP_ID' ] = self.adas_expid + '_LDAS4ens' | ||
| self.rqdExeInp[ 'MET_PATH' ] = self.adas_expdir +'/atmens/ensdiag/mem' |
There was a problem hiding this comment.
See comment above -- avoid adding "./ensdiag/" when we are already changing to "bkg"
There was a problem hiding this comment.
I will leave this in till we get bkg updates in and tested
There was a problem hiding this comment.
I guess the question is whether this PR needs to be merged before we can switch to the "bkg" convention for the lfo inputs to the LDAS. My preference would be to avoid merging this PR before we make the switch, but I'm not sure if that's workable
modified: GEOSldas_App/ldas_setup modified: GEOSmetforce_GridComp/LDAS_Forcing.F90
modified: GEOSldas_App/ldas_setup
updates are implemented to integrate ldas_setup in the coupled LADAS setup procedure. adas fvsetup calls ldas_setup with optional command line inputs, so that coupled ldas experiments are setup according to adas experiment specifications such as exp path, exp id, begin date and gid.
Related PR: GEOS-ESM/GEOSadas#327