-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heterogenous standard deviation for perturbation input from file #628
Conversation
src/Components/GEOSldas_GridComp/Shared/LDAS_TileCoordRoutines.F90
Outdated
Show resolved
Hide resolved
src/Components/GEOSldas_GridComp/GEOSlandpert_GridComp/LDAS_PertRoutines.F90
Outdated
Show resolved
Hide resolved
! NOTE: the input file is in netcdf, with a group 'std_force_pert', | ||
! and the grid is same as the *global* grid (tile_grid_g) (sqz 2/2023) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saraqzhang, I'm a bit confused by this statement. In line 661 above, there's a comment that when the model is on the cube-sphere tile space, the pert grid is a hard-wired lat/lon grid (with approximately the same resolution). The comment here (lines 1116-1117) and again below (lines 1510-1511) suggest that the pert grid is always tile_grid_g. But for the cube-sphere tile space, this isn't correct. Maybe I'm misunderstanding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tile_grid_g here is already a lat-lon grid generated here
call get_pert_grid(tile_grid_g, latlon_tmp_g) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment should be more clear: the grid in netcdf file is lat-lon grid, the resolution should match what "get_pert_grid(tile_grid_g, latlon_tmp_g) " generated.
it is left to user to find out what the resolution should be. ( for instance in a C180 run, it is 720x540)
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
2 similar comments
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving after edits of comments
(1) code fixed and tested for the option of input perturbation sdv.
(2) input file structure explained in notes inline.
note: Currently users need to read the src code to know the expected file structure. it may be helpful if a sample netcdf file and a reading/writing f90 code be added somewhere like in Util or App.