modified EnKF update_type 10 for PEATCLSM (include catdef in EnKF State) #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verification of new functionality completed successfully by @gmao-qliu and @gmao-rreichle. @biljanaorescanin, @weiyuan-jiang: Can you please approve (but not merge) this PR? I already completed the relevant Intel 0-diff tests for this PR. My plan is to merge this branch into that of #521 and then run a full set of 0-diff tests on the merged branch. Assuming everything passes as expected, I will then first merge this PR into develop and next merge #521 into develop. In a nutshell, I'm bundling the full set of 0-diff tests for this PR and #521. Thanks. |
biljanaorescanin
approved these changes
Feb 25, 2022
|
Passed full suite of 0-diff tests. #521 needs more work, so merging only this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A soil moisture analysis for a PEATCLSM tile should have catdef in the EnKF state vector, but the current default Tb analysis (update_type=10) does not (and should not for non-peat tiles because of the degradation in groundwater skill observed in Manuela's work).
This PR modifies update_type=10 to include catdef for PEATCLSM tiles.
Successfully 0-diff tested vs. develop for "conus", "global", and "globalcs".
Pending verification of new functionality.
cc: @gmao-qliu