Feature/narnold1/#560 shocmf updates #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… created plume exports with ungridded dim
tclune
reviewed
Jul 17, 2023
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
… run to make code more robust.
…S-ESM/GEOSgcm_GridComp into feature/narnold1/#560-shocmf-updates
…ed MF threshold for PRNUM, replaced Lmix with zpbl in L2, removed kludge on L3 and set min tkes at 0.1, moved PDF_A calc to update_moments, limit MF to below 2km topography, added EDMF_DEPTH diag
…PDF increment for ADG, added DKSS etc to TurbGC.
|
Updated the branch to remove the bugfix. Now 0-diff for all restarts except turb_internal_rst, turb_import_rst, and moist_import_rst, which are superficially affected by the HL to SL variable name changes. |
mathomp4
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensive updates to the SHOC-EDMF turbulence parameterizations.
This PR is non-0-diff due to fixing a bug in the calculation of (non-SHOC) TKE in GEOS_TurbulenceGridComp.F90. If bugfix is excluded, output fields are 0-diff.
This update also renames several SHOC variables (switching 'HL' to 'SL' for consistency with other model variables), which technically changes restart files. The affected variables are not used in default model configurations.